GutoVeronezi commented on a change in pull request #4878:
URL: https://github.com/apache/cloudstack/pull/4878#discussion_r654481594
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4684,11 +4683,15 @@ private VMInstanceVO orchestrateReConfigureVm(String
vmUuid, ServiceOffering old
new ScaleVmCommand(vm.getInstanceName(),
newServiceOffering.getCpu(), minSpeed,
newServiceOffering.getSpeed(), minMemory * 1024L *
1024L, newServiceOffering.getRamSize() * 1024L * 1024L,
newServiceOffering.getLimitCpuUse());
- Long dstHostId = vm.getHostId();
+ scaleVmCommand.getVirtualMachine().setId(vm.getId());
+ scaleVmCommand.getVirtualMachine().setUuid(vm.getUuid());
+ scaleVmCommand.getVirtualMachine().setType(vm.getType());
- if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
- HypervisorGuru hvGuru = _hvGuruMgr.getGuru(vm.getHypervisorType());
- Map<String, String> details =
hvGuru.getClusterSettings(vm.getId());
+ final Long dstHostId = vm.getHostId();
+ if(vm.getHypervisorType().equals(HypervisorType.VMware)) {
+ final HypervisorGuru hvGuru =
_hvGuruMgr.getGuru(vm.getHypervisorType());
+ Map<String, String> details = null;
+ details = hvGuru.getClusterSettings(vm.getId());
Review comment:
@DaanHoogland this was a lack of attention. Unnecessary changes undone,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
