GabrielBrascher opened a new pull request #4575:
URL: https://github.com/apache/cloudstack/pull/4575


   ### Description
   
   <!--- Describe your changes in DETAIL - And how has behavior functionally 
changed. -->
   
   Numbers are great for computers, however, we (humans) deal better with 
names. Logging host's ID is good in terms of short messages; however, admins 
must know all hosts by their ID or look via DB/API queries to figure out which 
host the log message is pointing to.
   
   This PR proposes an admin friendly approach for log messages by logging the 
host name instead of its ID.
   
   An example of how it works currently log messages can be painful in large 
environments:
   
   `Operation Failed vm's original host id: 334 new host id: 300 host id before 
state transition: 127`
   Vs.
   `Operation Failed vm's original host: node23.clusterA new host: 
node09.clusterA host before state transition: node01.clusterA`
   
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviors, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- 
*********************************************************************************
 -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE 
DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- 
*********************************************************************************
 -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to