DaanHoogland commented on a change in pull request #5148:
URL: https://github.com/apache/cloudstack/pull/5148#discussion_r657736804
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId,
VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
Review comment:
```suggestion
} else {
```
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
##########
@@ -253,6 +253,8 @@ public void deployVirtualMachine(String reservationId,
VMEntityVO vmEntityVO, St
}
_itMgr.start(vm.getUuid(), params, plan, null);
+ }else{
+ throw ex;
Review comment:
@GabrielBrascher, I tend to agree with @DK101010 but would it make sense
to cature the exception in a CloudStackException saying that we are "not
retrying as no host is given" ? and would that satisfy your requirements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
