huyle-uni commented on a change in pull request #4205:
URL: https://github.com/apache/cloudstack/pull/4205#discussion_r658460238



##########
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -243,10 +246,12 @@
     private KVMStoragePoolManager _storagePoolMgr;
 
     private VifDriver _defaultVifDriver;
+    private VifDriver _tungstenVifDriver;

Review comment:
       It is done, but to me, this "_" is like a special rule of Cloudstack 
when I first read Cloudstack code. And I'm pretty sure that 90% of newcomers 
will have the same thinking as I do




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to