Spaceman1984 opened a new pull request #4640: URL: https://github.com/apache/cloudstack/pull/4640
### Description This PR adds the ability to create thick and sparse disks using VMWare A global variable (disk.provisioning.type.strictness) has been added to select if disk provisioning types will be strictly adhered to, meaning if a storage pool is not capable of creating the specific disk provisioning type, the pool will not be selected for the creation of the volume. StoragePool capabilities are determined when the pool is added to Cloudstack and a new API is added ( updateStorageCapabilities(poolId) ) to update the hardware acceleration capability of storage pools if needed. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [x] Major - [x] Minor ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Marvin tests have been added and manual tests have been done using NFS without hardware acceleration and an ISCSI datastore. Create a thin/sparse/thick disk/service offering, set the global var to true, depending on the offering selected, the disks should be created in the correct storage pool with the correct disk provisioning type. If the global var is set to false, the disk will be created in any storage pool and if the pool supports the disk provisioning type it will be used, otherwise thin will be selected. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
