shwstppr commented on a change in pull request #5170:
URL: https://github.com/apache/cloudstack/pull/5170#discussion_r663905949
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -7337,20 +7337,20 @@ private Answer execute(PrepareUnmanageVMInstanceCommand
cmd) {
if (targetHyperHost != null) {
ManagedObjectReference morTargetHostDc =
targetHyperHost.getHyperHostDatacenter();
if
(!morSourceHostDc.getValue().equalsIgnoreCase(morTargetHostDc.getValue())) {
- String msg = "VM " + vmName + " cannot be migrated between
different datacenter";
+ String msg = String.format("VM: %s cannot be migrated
between different datacenter", vmName);
Review comment:
@GutoVeronezi `VirtualMachineTO` is not always available. It is
available only in case when this method `relocateVirtualMachine` is called for
`MigrateWithStorageCommand` while it remains null for `MigrateVolume` and
`MigrateVmToPoolCommand`
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -7445,7 +7443,7 @@ private Answer execute(PrepareUnmanageVMInstanceCommand
cmd) {
mgr.prepareSecondaryStorageStore(secStoreUrl, secStoreId);
ManagedObjectReference morSecDs =
prepareSecondaryDatastoreOnSpecificHost(secStoreUrl, targetHyperHost);
if (morSecDs == null) {
- String msg = "Failed to prepare secondary storage on host,
secondary store url: " + secStoreUrl;
+ String msg = String.format("Failed to prepare secondary
storage on host, secondary store url: %s", secStoreUrl);
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
