Spaceman1984 commented on a change in pull request #5187:
URL: https://github.com/apache/cloudstack/pull/5187#discussion_r666787861
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -188,7 +188,10 @@ for full help
sys.exit(1)
def setupDBSchema(self):
- if not self.rootuser:
+ if self.options.schemaonly and self.rootuser != None:
+ self.info("--schema-only and --deploy-as cannot be passed
together\n", None)
Review comment:
Done
##########
File path: setup/bindir/cloud-setup-databases.in
##########
@@ -248,21 +252,21 @@ for full help
p = os.path.join(self.dbFilesPath, 'server-setup.sql')
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
self.info(None, True)
for f in ["templates"]:
p = os.path.join(self.dbFilesPath,"%s.sql"%f)
text = open(p).read()
self.info("Applying %s"%p)
- self.runMysql(text, p, True)
+ self.runMysql(text, p, self.rootuser != None)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
