j-porsche commented on a change in pull request #5141:
URL: https://github.com/apache/cloudstack/pull/5141#discussion_r666880784
##########
File path: ui/docker.sh
##########
@@ -29,5 +29,20 @@ DATE="$(date --iso-8601=seconds)"
LABEL_DATE="--label \"org.opencontainers.image.created=${DATE}\""
GIT_REV="$(git rev-parse HEAD)"
LABEL_GIT_REV="--label \"org.opencontainers.image.revision=${GIT_REV}\""
+USE_PODMAN=0
+USE_DOCKER=0
+OPTIONS='pd'
+while getopts $OPTIONS OPTION
+do
+ case "$OPTION" in
+ p)USE_PODMAN=1;;
+ d)USE_DOCKER=1;;
+ *)echo "Please choose between -p for podman or -d for
docker.";;
+ esac
+done
+if [[ $USE_PODMAN -eq 1 ]]; then
+ podman build -t cloudstack-ui ${LABEL_DATE} ${LABEL_GIT_REV}
${LABEL_GIT_TAG}
Review comment:
@Niklas-Koch You missed the point at the end of the line 44
```suggestion
podman build -t cloudstack-ui ${LABEL_DATE} ${LABEL_GIT_REV}
${LABEL_GIT_TAG} .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
