soreana commented on a change in pull request #4141:
URL: https://github.com/apache/cloudstack/pull/4141#discussion_r668810151
##########
File path:
core/src/main/java/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java
##########
@@ -72,4 +81,36 @@ public NicTO getNic() {
public Long getVpcId() {
return vpcId;
}
+
+ public LoadBalancerConfigTO[] getNetworkLbConfigs() {
+ return this.networkLbConfigs;
+ }
+
+ public void setNetworkLbConfigs(List<? extends LoadBalancerConfig>
networkLbConfigs) {
+ if (networkLbConfigs == null || networkLbConfigs.size() == 0) {
Review comment:
@GutoVeronezi, As I mentioned before,
`org.apache.commons.lang3.ArrayUtils` package don't have isEmpty method which
accepts List object. I have to override it like:
```java
...
ArrayUtils.isEmpty(new List[]{lbConfigs})
...
```
It imposes unnecessary conversion. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
