GabrielBrascher commented on a change in pull request #5012:
URL: https://github.com/apache/cloudstack/pull/5012#discussion_r669057662
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2719,6 +2731,18 @@ private KVMPhysicalDisk
getPhysicalDiskPrimaryStore(PrimaryDataStoreTO primaryDa
return storagePool.getPhysicalDisk(data.getPath());
}
+ /**
+ * Set Disk IO Driver, if supported by the Libvirt/Qemu version.
+ * IO Driver works for:
+ * (i) Qemu >= 5.0;
+ * (ii) Libvirt >= 6.3.0
+ */
+ protected void setDiskIoDriver(DiskDef disk) {
+ if (getHypervisorLibvirtVersion() >=
HYPERVISOR_LIBVIRT_VERSION_SUPPORTS_IO_URING && getHypervisorQemuVersion() >=
HYPERVISOR_QEMU_VERSION_SUPPORTS_IO_URING) {
Review comment:
@rhtyd as far as I know there are no issues with different types of
guest OS.
This would impact the Hypervisor side; thus, it is important that the
virtualization layer supports it.
As far as I know, both Ubuntu and Centos would support as long as the `Qemu
>= 5.0` and `Libvirt >= 6.3.0`.
One issue that I have seen with this proposed implementation is when (live)
migrating from a KVM node that supports IO_URING to one that does not. I will
check how to update the IO Driver when migrating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
