DK101010 commented on pull request #5194:
URL: https://github.com/apache/cloudstack/pull/5194#issuecomment-880430878


   > Other than the compilation issue, code changes are correct based on the 
premise that broadcast URI for PVLAN will be based on its type and the first 
character of the type string.
   > 
   > @DK101010 since we do not have any smoke to test VM import, it will be 
great if you can add API call/output for testing this change
   
   Do you want this ? 
   
   ``` console
   import unmanagedinstance clusterid=b6dc2477-f3ec-43e2-a405-3605e29aaa42 
name=VM-ac60ee4e-7231-4057-8ff6-40f0c9eacd04 
displayname=VM-ac60ee4e-7231-4057-8ff6-40f0c9eacd04 
serviceofferingid=35d68014-0257-4775-b256-49a009aa5750
   ````
   
   ```JSON
   {
     "accountid": "226c8611-ff24-11ea-9d07-005056827a97",
     "cmd": 
"org.apache.cloudstack.api.command.admin.vm.ImportUnmanagedInstanceCmd",
     "completed": "2021-07-15T07:18:39+0100",
     "created": "2021-07-15T07:18:36+0100",
     "jobid": "c07d365c-7057-4124-bf6b-ce4efbe2ca1b",
     "jobprocstatus": 0,
     "jobresult": {
       "virtualmachine": {
         "account": "admin",
         "affinitygroup": [],
         "cpunumber": 1,
         "cpuspeed": 0,
         "created": "2021-07-15T07:18:38+0100",
         "details": {
           "dataDiskController": "osdefault",
           "deployvm": "true",
           "nicAdapter": "E1000",
           "rootDiskController": "pvscsi"
         },
         "displayname": "VM-ac60ee4e-7231-4057-8ff6-40f0c9eacd04",
         "displayvm": true,
         "domain": "ROOT",
         "domainid": "226c46c2-ff24-11ea-9d07-005056827a97",
         "guestosid": "224af937-ff24-11ea-9d07-005056827a97",
         "haenable": false,
         "hostid": "73676017-b962-4942-bb4c-cf297634b212",
         "hostname": "iosvemt01.esx-tst.os.itelligence.de",
         "hypervisor": "VMware",
         "id": "93309b0b-8af7-4ad2-85ea-a7e492b9af2e",
         "instancename": "VM-ac60ee4e-7231-4057-8ff6-40f0c9eacd04",
         "isdynamicallyscalable": false,
         "memory": 1024,
         "name": "VM-ac60ee4e-7231-4057-8ff6-40f0c9eacd04",
         "nic": [
           {
             "broadcasturi": "vlan://2",
             "extradhcpoption": [],
             "id": "3d4d8f5e-2ce6-4575-91c8-9d367520d97c",
             "isdefault": true,
             "isolationuri": "vlan://2",
             "macaddress": "02:00:07:e5:00:60",
             "networkid": "85d27cc3-9184-4d7f-87c4-e5b08b2eb2cc",
             "networkname": "Guest",
             "secondaryip": [],
             "traffictype": "Guest",
             "type": "L2"
           }
         ],
         "osdisplayname": "Other Ubuntu (64-bit)",
         "ostypeid": "224af937-ff24-11ea-9d07-005056827a97",
         "passwordenabled": false,
         "rootdeviceid": 0,
         "rootdevicetype": "ROOT",
         "securitygroup": [],
         "serviceofferingid": "35d68014-0257-4775-b256-49a009aa5750",
         "serviceofferingname": "testCPU0Mhz",
         "state": "Running",
         "tags": [],
         "templatedisplaytext": "VM Import Default Template",
         "templateid": "59faead6-743e-442f-a964-ffb31da3e785",
         "templatename": "system-default-vm-import-dummy-template.iso",
         "userid": "22712228-ff24-11ea-9d07-005056827a97",
         "username": "admin",
         "zoneid": "de1c4b6f-a58b-46e6-9418-1fd55a9f022c",
         "zonename": "eu-de-vct5"
       }
     },
     "jobresultcode": 0,
     "jobresulttype": "object",
     "jobstatus": 1,
     "userid": "22712228-ff24-11ea-9d07-005056827a97"
   }
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to