RodrigoDLopez commented on pull request #4585: URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-881539086
Hey @GutoVeronezi Thank you for your contribution. You're doing an pretty job. @DaanHoogland @GabrielBrascher @rhtyd I ran some manual tests on this branch, and as far as I could verify everything works correctly. Before upgrading to this branch, the agents log was always the same. Something like: ``` DEBUG [kvm.resource.KVMHAMonitor] Executing: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 201.200.102.10 -p /export/primary2 -m /mnt/8c8fbcc3-eeef-33c1-adf6-51b915df61ca -h 201.200.101.4 DEBUG [kvm.resource.KVMHAMonitor] Executing while with timeout : 60000 DEBUG [kvm.resource.KVMHAMonitor] Execution is successful. ``` After updating, I ran some tests changing the parameter value and checking if the default value would be used. * with the default value of heartbeat.update.timeout (commented or missing parameter) ``` DEBUG [kvm.resource.KVMHAMonitor] Executing: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 201.200.102.10 -p /export/primary2 -m /mnt/8c8fbcc3-eeef-33c1-adf6-51b915df61ca -h 201.200.101.4 DEBUG [kvm.resource.KVMHAMonitor] Executing while with timeout : 60000 DEBUG [kvm.resource.KVMHAMonitor] Execution is successful. ``` * heartbeat.update.timeout=30000 ``` DEBUG [kvm.resource.KVMHAMonitor] Executing: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 201.200.102.10 -p /export/primary2 -m /mnt/8c8fbcc3-eeef-33c1-adf6-51b915df61ca -h 201.200.101.4 DEBUG [kvm.resource.KVMHAMonitor] Executing while with timeout : 30000 DEBUG [kvm.resource.KVMHAMonitor] Execution is successful. ``` * heartbeat.update.timeout=10000 ``` DEBUG [kvm.resource.KVMHAMonitor] Executing: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 201.200.102.10 -p /export/primary2 -m /mnt/8c8fbcc3-eeef-33c1-adf6-51b915df61ca -h 201.200.101.4 DEBUG [kvm.resource.KVMHAMonitor] Executing while with timeout : 10000 DEBUG [kvm.resource.KVMHAMonitor] Execution is successful. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
