[GitHub] [cloudstack] shwstppr commented on pull request #5075: ui: vmware vm import-unmanage

[GitBox]

shwstppr commented on pull request #5075:
URL: https://github.com/apache/cloudstack/pull/5075#issuecomment-882293658


   @andrijapanicsb Fixed conflicts
   Commit in question b3e2ace changed the tooltip code for form items.
   ![Screenshot from 2021-07-19 
12-23-02](https://user-images.githubusercontent.com/153340/126115809-31f0bec3-2d56-43dd-8659-8e364540f45e.png)
   Before 041948c (#5133), above icon was shown with code,
   ```
   <span slot="label">
     {{ $t('label.displayname') }}
     <a-tooltip :title="apiParams.displayname.description">
       <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
     </a-tooltip>
   </span>
   ```
   With PR #5133, new Vue component (TooltipLabel.vue) was added which allowed 
above code to be refactored as,
   ```
   <tooltip-label slot="label" :title="$t('label.displayname')" 
:tooltip="apiParams.displayname.description"/>
   ```
   PR #5133 was merged into `main` after your review.
   
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org