sureshanaparti commented on a change in pull request #5163:
URL: https://github.com/apache/cloudstack/pull/5163#discussion_r672175543
##########
File path: server/src/main/java/com/cloud/uuididentity/UUIDManagerImpl.java
##########
@@ -119,7 +119,9 @@ public boolean IsUuidFormat(String uuid) {
}
Identity identity = (Identity) this._entityMgr.findById(entityType,
customId);
Review comment:
@DaanHoogland my suggestion is if entityType is null, better throw
exception as below
```
InvalidParameterValueException("Unknown entity type")
```
and when identity is null (here entityType is not null), better throw
exception as below
```
throw new InvalidParameterValueException(String.format("Unable to find UUID
for id [%s] of type [%s]",
customId, entityType.getSimpleName()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
