DaanHoogland commented on pull request #4585:
URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-882565561


   I found an issue after merging this. addHost fails in several environments:
   ```
   /agent.properties /etc/cloudstack/agent/
   SSH command output:
   cat: /etc/cloudstack/agent/cloud.csr: No such file or directory
   chmod: cannot access '/etc/cloudstack/agent/cloud.csr': No such file or 
directory
   2021-07-19 13:46:10,300 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373) Executing cmd: 
sudo /usr/share/cloudstack-common/scripts/util/keystore-setup 
/etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   2021-07-19 13:46:11,624 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-11:null) (logid:) SeqA 3-437166: Processing Seq 3-437166: 
 { Cmd , MgmtId: -1, via: 3, Ver: v1, Flags: 11, 
[{"com.cloud.agent.api.ConsoleProxyLoadReportCommand":{"_proxyVmId":"2","_loadInfo":"{
     "connections": []
   }","wait":"0","bypassHostMaintenance":"false"}}] }
   2021-07-19 13:46:11,627 DEBUG [c.c.a.m.AgentManagerImpl] 
(AgentManager-Handler-11:null) (logid:) SeqA 3-437166: Sending Seq 3-437166:  { 
Ans: , MgmtId: 32987898970999, via: 3, Ver: v1, Flags: 100010, 
[{"com.cloud.agent.api.AgentControlAnswer":{"result":"true","wait":"0","bypassHostMaintenance":"false"}}]
 }
   2021-07-19 13:46:12,333 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373) SSH command: sudo 
/usr/share/cloudstack-common/scripts/util/keystore-setup 
/etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   SSH command output:
   cat: /etc/cloudstack/agent/cloud.csr: No such file or directory
   chmod: cannot access '/etc/cloudstack/agent/cloud.csr': No such file or 
directory
   2021-07-19 13:46:12,333 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373) Executing cmd: 
sudo /usr/share/cloudstack-common/scripts/util/keystore-setup 
/etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   2021-07-19 13:46:13,330 DEBUG [o.a.c.h.HAManagerImpl] 
(BackgroundTaskPollManager-6:ctx-c7b3d575) (logid:a7a1aba2) HA health check 
task is running...
   2021-07-19 13:46:14,362 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373) SSH command: sudo 
/usr/share/cloudstack-common/scripts/util/keystore-setup 
/etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   SSH command output:
   cat: /etc/cloudstack/agent/cloud.csr: No such file or directory
   chmod: cannot access '/etc/cloudstack/agent/cloud.csr': No such file or 
directory
   2021-07-19 13:46:14,363 WARN  [c.c.h.k.d.LibvirtServerDiscoverer] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373)  can't setup 
agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup 
keystore on the KVM host: 10.0.34.223 - Failed to setup keystore on the KVM 
host: 10.0.34.223
   2021-07-19 13:46:14,364 WARN  [c.c.r.ResourceManagerImpl] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373) Unable to find 
the server resources at http://10.0.34.223
   2021-07-19 13:46:14,364 INFO  [c.c.u.e.CSExceptionErrorCode] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373) Could not find 
exception: com.cloud.exception.DiscoveryException in error code list for 
exceptions
   2021-07-19 13:46:14,365 WARN  [o.a.c.a.c.a.h.AddHostCmd] 
(qtp1233705144-20:ctx-9944ed37 ctx-cd993147) (logid:b0400373) Exception: 
   com.cloud.exception.DiscoveryException: Unable to add the host
        at 
com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:845)
        at 
com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:631)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at com.sun.proxy.$Proxy194.discoverHosts(Unknown Source)
        at 
org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
        at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:156)
        at com.cloud.api.ApiServer.queueCommand(ApiServer.java:764)
        at com.cloud.api.ApiServer.handleRequest(ApiServer.java:588)
        at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:321)
        at com.cloud.api.ApiServlet$1.run(ApiServlet.java:134)
        at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
        at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
        at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
        at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:131)
        at com.cloud.api.ApiServlet.doPost(ApiServlet.java:98)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:665)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
        at 
org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1443)
        at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:791)
        at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:550)
        at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
        at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:602)
        at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
        at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
        at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1435)
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
        at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501)
        at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
        at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1350)
        at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
        at 
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:766)
        at 
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
        at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
        at org.eclipse.jetty.server.Server.handle(Server.java:516)
        at 
org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:388)
        at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:633)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380)
        at 
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
        at 
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
        at 
org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:773)
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:905)
        at java.base/java.lang.Thread.run(Thread.java:829)
   ```
   I think we'll need to revert (which I'm testing now in a lab env)
   the smoke tests succeeded so the problem is not this PR in isolation, but 
something got merged that conflicted with this probably.
   
   cc @GutoVeronezi @GabrielBrascher @RodrigoDLopez @nvazquez 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to