utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678817325



##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
 
           // Ensure we refresh on the same / parent page
           const currentPage = this.$router.currentRoute.path
-          const samePage = originalPage === currentPage || 
originalPage.startsWith(currentPage + '/')
+          const samePage = options.originalPage === currentPage || 
options.originalPage.startsWith(currentPage + '/')

Review comment:
       What do you think about my suggestion?
   `const originalPagePath = originalPage || this.$router.currentRoute.path`
   and
   `const samePage = originalPagePath === currentPage || 
originalPagePath.startsWith(currentPage + '/')`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to