rhtyd commented on pull request #4699: URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-889626735
I've left remarks already what's missing, the PR doesn't fully satisfy all the requirements for the issue I had logged in 2019 https://github.com/apache/cloudstack/issues/3609 while it indeed implements the sql logic but for me that's not enough. If the PR author doesn't want to work to satisfy the requirements asked in the issue and in the review then I personally don't like us to include half baked solutions that add debt for others to fix in future. Furthermore I see @Spaceman1984 doing something about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
