RodrigoDLopez commented on a change in pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#discussion_r680003213
##########
File path:
api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -911,4 +919,12 @@ public String getOsDisplayName() {
public String getPoolType() { return poolType; }
public void setPoolType(String poolType) { this.poolType = poolType; }
+
+ public void setBytesReceived(final Long bytesReceived) {
+ this.bytesReceived = bytesReceived;
+ }
+
+ public void setBytesSent(final Long bytesSent) {
Review comment:
and here.
##########
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##########
@@ -365,9 +370,26 @@ public UserVmResponse newUserVmResponse(ResponseView view,
String objectName, Us
userVmResponse.setDynamicallyScalable(userVm.isDynamicallyScalable());
}
+ addVmRxTxDataToResponse(userVm, userVmResponse);
+
return userVmResponse;
}
+ private void addVmRxTxDataToResponse(final UserVmJoinVO userVm, final
UserVmResponse userVmResponse) {
Review comment:
and again. here.
##########
File path:
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
##########
@@ -495,4 +503,12 @@ public Date getCreated() {
public void setCreated(Date created) {
this.created = created;
}
+
+ public void setBytesReceived(final Long bytesReceived) {
Review comment:
I don't fully understand why the key 'final' is being used here. You
don't need to use it here.
am I wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
