DaanHoogland commented on pull request #4776: URL: https://github.com/apache/cloudstack/pull/4776#issuecomment-890101931
> Code LGTM. > But to me seems like you are using the key 'final' where we don't need it. > > Did I understood something wrong? > > Do we need more manual test on this PR? since @nvazquez has already did some tests. It is, in some circles, good practice to make sure a parameter is only changed consciously. A bit overdone indeed, i would agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
