nvazquez commented on a change in pull request #5254:
URL: https://github.com/apache/cloudstack/pull/5254#discussion_r682231820
##########
File path:
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java
##########
@@ -571,6 +571,13 @@ public boolean startKubernetesClusterOnCreate() {
if (!isKubernetesClusterDashboardServiceRunning(true,
startTimeoutTime)) {
logTransitStateAndThrow(Level.ERROR, String.format("Failed to
setup Kubernetes cluster : %s in usable state as unable to get Dashboard
service running for the cluster", kubernetesCluster.getName()),
kubernetesCluster.getId(),KubernetesCluster.Event.OperationFailed);
}
+ retrieveScriptFiles();
+ copyScripts(publicIpAddress, sshPort);
Review comment:
What about creating a method for these lines on
`KubernetesClusterActionWorket` and invoke it here and on
`KubernetesClusterActionWorket` instead of lines 475-482
##########
File path:
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java
##########
@@ -571,6 +571,13 @@ public boolean startKubernetesClusterOnCreate() {
if (!isKubernetesClusterDashboardServiceRunning(true,
startTimeoutTime)) {
logTransitStateAndThrow(Level.ERROR, String.format("Failed to
setup Kubernetes cluster : %s in usable state as unable to get Dashboard
service running for the cluster", kubernetesCluster.getName()),
kubernetesCluster.getId(),KubernetesCluster.Event.OperationFailed);
}
+ retrieveScriptFiles();
+ copyScripts(publicIpAddress, sshPort);
Review comment:
What about creating a method for these lines on
`KubernetesClusterActionWorket` and invoke it here and on
`KubernetesClusterActionWorket` instead of lines 475-482?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
