nvazquez commented on a change in pull request #5270:
URL: https://github.com/apache/cloudstack/pull/5270#discussion_r683933246
##########
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##########
@@ -300,6 +300,9 @@
@Inject
private EndPointSelector selector;
+ private final static String VMWARE_TOOLS_ISO = "vmware-tools.iso";
Review comment:
Just an improvement suggestion: I've noticed these ISO names are
hardcoded on the Vmware and Xen plugins codebase. What about moving
`VMWARE_TOOLS_ISO` and `XS_TOOLS_ISO` to the `TemplateManager` interface and
replace the hardcoded ISO names for these values on the
`plugins/hypervisor/vmware` and `plugins/hypervisor/xenserver` modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
