DaanHoogland commented on a change in pull request #5264:
URL: https://github.com/apache/cloudstack/pull/5264#discussion_r683987665
##########
File path:
engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -365,6 +365,8 @@ public void check() {
}
final CloudStackVersion currentVersion =
CloudStackVersion.parse(currentVersionValue);
+ SystemVmTemplateRegistration.CS_MAJOR_VERSION =
String.valueOf(currentVersion.getMajorRelease()) + "." +
String.valueOf(currentVersion.getMinorRelease());
+ SystemVmTemplateRegistration.CS_MINOR_VERSION =
String.valueOf(currentVersion.getPatchRelease());
Review comment:
```suggestion
SystemVmTemplateRegistration.CS_MAJOR_VERSION =
String.valueOf(currentVersion.getMajorRelease()) + "." +
String.valueOf(currentVersion.getMinorRelease());
SystemVmTemplateRegistration.CS_TINY_VERSION =
String.valueOf(currentVersion.getPatchRelease());
```
##########
File path:
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java
##########
@@ -75,8 +75,8 @@
private static final String UPDATE_CONFIGURATION_TABLE = "UPDATE
`cloud`.`configuration` SET value = ? WHERE name = ?";
private static final String UPDATE_TEMPLATE_TABLE_ON_FAILURE = "UPDATE
vm_template set removed = ?, state = 'Inactive' where id = ?";
private static final String DELETE_TEMPLATE_REF_RECORD_ON_FAILURE =
"DELETE from template_store_ref where template_id = ?";
- public static final String CS_MAJOR_VERSION = "4.16";
- public static final String CS_MINOR_VERSION = "0";
+ public static String CS_MAJOR_VERSION = "4.16";
+ public static String CS_MINOR_VERSION = "0";
Review comment:
```suggestion
public static String CS_TINY_VERSION = "0";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
