ravening commented on pull request #5249: URL: https://github.com/apache/cloudstack/pull/5249#issuecomment-895194403
> Overall code LGTM, I see that @DaanHoogland made some interesting suggestions. I would appreciate it if you take them into account. But either way, LGTM. > > Thanks for the PR @ravening. > Has this been tested? Manual tests might be interesting in this one with some alternatives for the global settings. @GabrielBrascher will work on it to make changes. Yes I tested them manually by passing uuid of particular pool in the global setting. All of the vm deployment, volume attachment to a vm will happen on this pool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
