nvazquez commented on a change in pull request #4966:
URL: https://github.com/apache/cloudstack/pull/4966#discussion_r687347799
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -572,19 +571,19 @@ protected void advanceExpunge(VMInstanceVO vm) throws
ResourceUnavailableExcepti
final HypervisorGuru hvGuru =
_hvGuruMgr.getGuru(vm.getHypervisorType());
- s_logger.debug("Cleaning up NICS");
- final List<Command> nicExpungeCommands =
hvGuru.finalizeExpungeNics(vm, profile.getNics());
Review comment:
Why are we removing these commands? Checked the Vmware guru may need
`UnregisterNicCommand` processing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
