GutoVeronezi commented on a change in pull request #5297:
URL: https://github.com/apache/cloudstack/pull/5297#discussion_r694234874
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -231,9 +229,14 @@
@Inject
VolumeApiService _volumeApiService;
+ @Inject
+ protected SnapshotHelper snapshotHelper;
+
private final StateMachine2<Volume.State, Volume.Event, Volume>
_volStateMachine;
protected List<StoragePoolAllocator> _storagePoolAllocators;
+ protected boolean backupSnapshotAfterTakingSnapshot =
BackupSnapshotAfterTakingSnapshot.value();
Review comment:
@nvazquez as it is a `boolean` setting, ACS does not allow operators to
inform anything different from `true` or `false`. If the setting is null by
some reason, the `value()` will return the default value. If we directly change
the setting in the database to something different from `true` or `false`, ACS
will validate it with `Boolean.valueOf()`, which will use
`"true".equalsIgnoreCase(s)` to verify it. With that said, I don't see a case
which the setting will be null.
Do I am missing or misunderstanding anything in the process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
