Pearl1594 commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r695810139



##########
File path: tools/appliance/systemvmtemplate/scripts/configure_conntrack.sh
##########
@@ -34,8 +34,6 @@ function load_conntrack_modules() {
   grep nf_conntrack_ipv4 /etc/modules && return
 
   cat >> /etc/modules << EOF
-nf_conntrack_ipv4
-nf_conntrack_ipv6

Review comment:
       there is only an nf_conntrack module, it is because of these unknown 
modules that we see an error during systemvm bootup
   
![image](https://user-images.githubusercontent.com/10495417/130806187-ac5896b4-acb6-415d-986a-f356643a6fef.png)
   

##########
File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
##########
@@ -69,23 +75,33 @@ function install_packages() {
     radvd \
     sharutils genisoimage \
     strongswan libcharon-extra-plugins libstrongswan-extra-plugins 
strongswan-charon strongswan-starter \
-    virt-what open-vm-tools qemu-guest-agent hyperv-daemons
+    virt-what open-vm-tools qemu-guest-agent hyperv-daemons cloud-guest-utils \
+    conntrack apt-transport-https ca-certificates curl gnupg  gnupg-agent 
software-properties-common
+
+  apt-get install -y python3-json-pointer python3-jsonschema cloud-init
 
   # python2-netaddr workaround
   wget 
https://github.com/shapeblue/cloudstack-nonoss/raw/main/python-netaddr_0.7.19-1_all.deb
   dpkg -i python-netaddr_0.7.19-1_all.deb
 
-  apt-get -y autoremove --purge
-  apt-get clean
-  apt-get autoclean
+  apt_clean
 
-  #32 bit architecture support for vhd-util: not required for 32 bit template
+  # 32 bit architecture support for vhd-util
   if [ "${arch}" != "i386" ]; then
     dpkg --add-architecture i386
     apt-get update
     ${apt_get} install libuuid1:i386 libc6:i386
   fi
 
+  # Install docker and containerd for CKS
+  curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -
+  apt-key fingerprint 0EBFCD88
+  add-apt-repository "deb [arch=amd64] 
https://download.docker.com/linux/debian $(lsb_release -cs) stable"
+  apt-get update
+  ${apt_get} install docker-ce docker-ce-cli containerd.io

Review comment:
       +1 - will work on it in the next phase




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to