RodrigoDLopez commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-905701605
@PaulAngus Now I do understand your viewpoint. But I don't see the lack of attention as a risk. Using the same approach, I would say that we need to lock many parameters to ensure the offering will be created at the right domain and this is not the reality of ACS, we have some flexibility at some points. But "With great power comes great responsibility" In my opinion, the proposal is too simple and will bring more flexibility to create offerings. Again, I can't see any damage caused by enabling subdomain admins to create offerings without pass the domain id, but they need to pay attention to what are they doing. I agree with @GabrielBrascher > I would be "-1" only in the case of a domain admin creating public offerings when the domain ID is NULL. However, this has been already checked and that's not the case here. We already checked this point, and the created offering won't be a public one. @ravening you do have my **+1** on this one. But for this, we need to update the API description @PaulAngus, @DaanHoogland Is there anything else that could be done by @ravening to proceed with this proposal? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
