DaanHoogland commented on a change in pull request #5335:
URL: https://github.com/apache/cloudstack/pull/5335#discussion_r697215644
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java
##########
@@ -122,6 +123,15 @@
private String xenServerIsoName = TemplateManager.XS_TOOLS_ISO;
private String xenServerIsoDisplayText = "XenServer Tools Installer ISO
(xen-pv-drv-iso)";
+ public final static String MIN_UEFI_SUPPORTED_VERSION = "8.2";
+
+ public static boolean isUefiSupported(String hostProductVersion) {
+ if (StringUtils.isEmpty(hostProductVersion)) {
+ return false;
+ }
+ return hostProductVersion.compareTo(MIN_UEFI_SUPPORTED_VERSION) >= 0;
Review comment:
is this comparitor able to decide 10.3 > 8.2? I think this needs more
robustness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
