rhtyd commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r697291233
##########
File path: ui/src/components/view/ResourceView.vue
##########
@@ -135,27 +135,8 @@ export default {
this.$emit('onTabChange', key)
},
showTab (tab) {
- if ('networkServiceFilter' in tab) {
- if (this.resource && this.resource.virtualmachineid &&
!this.resource.vpcid && tab.name !== 'firewall') {
- return false
- }
- if (this.resource && this.resource.virtualmachineid &&
this.resource.vpcid) {
- return false
- }
- // dont display any option for source NAT IP of VPC
- if (this.resource && this.resource.vpcid && !this.resource.issourcenat
&& tab.name !== 'firewall') {
- return true
- }
- // display LB and PF options for isolated networks if static nat is
disabled
- if (this.resource && !this.resource.vpcid) {
- if (!this.resource.isstaticnat) {
- return true
- } else if (tab.name === 'firewall') {
- return true
- }
- }
- return this.networkService && this.networkService.service &&
- tab.networkServiceFilter(this.networkService.service)
+ if (this.networkService && this.networkService.service &&
tab.networkServiceFilter) {
Review comment:
@davidjumani can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
