GutoVeronezi opened a new pull request #5386: URL: https://github.com/apache/cloudstack/pull/5386
### Description We have a current discussion about using `commons.lang3` or our facade `com.cloud.utils` on the code, however a third implementation has been added (`google.common.base`), which end up adding more complexity to the discussion. The two variables of this discussion already implements all we need, therefore adding a third one does not make sense. This PR primary intends to change `com.google.common.base.Strings`'s calls for `org.apache.commons.lang3.StringUtils`'s calls and after that, upgrade `org.apache.commons.lang.StringUtils`'s calls to `org.apache.commons.lang3.StringUtils`'s calls. Also, it will improve some minor codes related to `org.apache.commons.lang3.StringUtils` methods; I choose `org.apache.commons.lang3.StringUtils` because our facade `com.cloud.utils.StringUtils` has a lack of methods to be a really facade of `org.apache.commons.lang3.StringUtils` and the methods it already implements are `deprecated`. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### How Has This Been Tested? - -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
