shwstppr commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r699002144
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1241,6 +1241,7 @@ private void postCreatePrivateTemplate(String
installFullPath, long templateId,
ManagedObjectReference morPool =
hyperHost.getHyperHostOwnerResourcePool();
vmMo.createFullCloneWithSpecificDisk(templateUniqueName,
dcMo.getVmFolder(), morPool,
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()),
volumeDeviceInfo);
clonedVm = dcMo.findVm(templateUniqueName);
+ s_logger.debug(String.format("Cloned VM: %s as %s",
vmMo.getName(), clonedVm.getName()));
Review comment:
Done
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -3764,24 +3766,24 @@ private Long
restoreVolumeFromSecStorage(VmwareHypervisorHost hyperHost, Datasto
throw new Exception(msg);
}
- VirtualMachineMO clonedVm = null;
+ VirtualMachineMO workerVm = null;
Review comment:
I feel `workerVm` suits more here as we use the VM just to import the
OVF created for volume that is to be restored from sec store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
