shwstppr commented on a change in pull request #4534:
URL: https://github.com/apache/cloudstack/pull/4534#discussion_r701565289
##########
File path: server/src/main/java/com/cloud/deploy/FirstFitPlanner.java
##########
@@ -441,7 +441,22 @@ protected void removeClustersCrossingThreshold(List<Long>
clusterListForVmAlloca
return podIdsByCapacity;
}
- protected Pair<List<Long>, Map<Long, Double>> listClustersByCapacity(long
id, int requiredCpu, long requiredRam, ExcludeList avoid, boolean isZone) {
+ private List<Long> listDisabledClusters(long zoneId, Long podId) {
+ List<Long> disabledClusters = clusterDao.listDisabledClusters(zoneId,
podId);
+ if (podId == null) {
+ //list all disabled clusters under this zone + clusters under any
disabled pod of this zone
+ List<Long> clustersWithDisabledPods =
clusterDao.listClustersWithDisabledPods(zoneId);
+ disabledClusters.addAll(clustersWithDisabledPods);
+ }
+ return disabledClusters;
+ }
+
+ private List<Long> listDisabledPods(long zoneId) {
+ List<Long> disabledPods = podDao.listDisabledPods(zoneId);
+ return disabledPods;
+ }
Review comment:
@weizhouapache these methods are not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
