shwstppr commented on a change in pull request #5390:
URL: https://github.com/apache/cloudstack/pull/5390#discussion_r703301916
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -892,6 +892,7 @@ public UserVm resetVMSSHKey(ResetVMSSHKeyCmd cmd) throws
ResourceUnavailableExce
}
protected void removeEncryptedPasswordFromUserVmVoDetails(UserVmVO
userVmVo) {
+ _vmDao.loadDetails(userVmVo);
Review comment:
@weizhouapache yes, VM details are updated by `resetVMSSHKeyInternal`
and that is why I feel `loadDetails` at 859 can be removed as I don't see it
being used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
