rhtyd commented on pull request #4276: URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-919759979
LGTM - but this may break something in UI, for example in UI listall=true is passed; so as a root admin user/account you'll be now able to see all VMs across all projects; and some actions may require the passing of projectid when doing some operation with resources owned by a project. A failure case may be, in UI we see all VMs, and root admin selects a VM that belongs to a project and tries to say attach a volume or network to the VM that doesn't belong to the project -> some error/exception/security issue could be caused. Maybe I'm overthinking, @GabrielBrascher can you explore in this direction and advise if this could cause any regression in UI or operation issue like I've described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
