DaanHoogland commented on pull request #4634: URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921660539
-0 if we allow for a mix of concerns in manager implementations we will increase the number of code conflict we will get over time. We should strive for better separation as much as possible. I'm not going to block this simple fix over this but it is an increasing concern. Calls to DAOs could have been made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
