Pearl1594 commented on a change in pull request #5428:
URL: https://github.com/apache/cloudstack/pull/5428#discussion_r714476892
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2584,6 +2585,54 @@ protected void runInContext() {
}
}
+ private void verifyVmLimits(UserVmVO vmInstance, Map<String, String>
details) {
+ if (VirtualMachineManager.ResourceCountRunningVMsonly.value()) {
Review comment:
Just to confirm before making the change - @weizhouapache this is to
ensure that before updating the VM settings for cpuNumber/ memory - we validate
it is within the limits of the custom offering it uses (if it uses)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
