weizhouapache commented on a change in pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#discussion_r714712808
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -851,6 +861,159 @@ public Configuration updateConfiguration(final
UpdateCfgCmd cmd) throws InvalidP
}
}
+ private ParamCountPair getParamCount(Map<String, Long> scopeMap) {
+ Long id = null;
+ int paramCount = 0;
+ String scope = ConfigKey.Scope.Global.toString();
+
+ for (var entry : scopeMap.entrySet()) {
+ if (entry.getValue() != null) {
+ id = entry.getValue();
+ scope = entry.getKey();
+ paramCount++;
+ }
+ }
+
+ return new ParamCountPair(id, paramCount, scope);
+ }
+
+ @Override
+ @ActionEvent(eventType = EventTypes.EVENT_CONFIGURATION_VALUE_EDIT,
eventDescription = "resetting configuration")
+ public Pair<Configuration, String> resetConfiguration(final ResetCfgCmd
cmd) throws InvalidParameterValueException {
+ final Long userId = CallContext.current().getCallingUserId();
+ final String name = cmd.getCfgName();
+ final Long zoneId = cmd.getZoneId();
+ final Long clusterId = cmd.getClusterId();
+ final Long storagepoolId = cmd.getStoragepoolId();
+ final Long accountId = cmd.getAccountId();
+ final Long domainId = cmd.getDomainId();
+ final Long imageStoreId = cmd.getImageStoreId();
+ Optional optionalValue;
+ final ConfigKey<?> configKey = _configDepot.get(name);
+ if (configKey == null) {
+ s_logger.warn("Probably the component manager where configuration
variable " + name + " is defined needs to implement Configurable interface");
+ throw new InvalidParameterValueException("Config parameter with
name " + name + " doesn't exist");
+ }
+ String defaultValue = configKey.defaultValue();
+ String category = configKey.category();
+ String configScope = configKey.scope().toString();
+
+ String scope = "";
+ Map<String, Long> scopeMap = new LinkedHashMap<>();
Review comment:
order is not important, right ? build failures caused by unimported
LinkedHashMap class.
```suggestion
Map<String, Long> scopeMap = new HashMap<>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
