weizhouapache commented on a change in pull request #5501:
URL: https://github.com/apache/cloudstack/pull/5501#discussion_r715570210
##########
File path:
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
##########
@@ -1558,7 +1558,8 @@ protected boolean hostCanAccessSPool(Host host,
StoragePool pool) {
DiskOfferingVO diskOffering =
_diskOfferingDao.findById(toBeCreated.getDiskOfferingId());
- if (vmProfile.getTemplate().getFormat() == Storage.ImageFormat.ISO
&& vmProfile.getServiceOffering().getTagsArray().length != 0) {
+ if ((vmProfile.getTemplate().getFormat() ==
Storage.ImageFormat.ISO || toBeCreated.getVolumeType() == Volume.Type.ROOT)
+ && vmProfile.getServiceOffering().getTagsArray().length !=
0) {
Review comment:
@sureshanaparti
yes, you are right. it is not required. this is why I converted this PR to
draft today.
I thought I have reproduced the issue two days before. but today I am not
able to reproduce.
I am still investigating the issue #4406
When I find some clue I will update and reopen this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
