weizhouapache commented on pull request #5446: URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-929020091
> @sureshanaparti did you ping the interested parties for testing? Or do you have any advise on testing? @sureshanaparti @DaanHoogland @nvazquez I think nobody is using this setting now (advanced zone with GRE isolation) as the feature was broken in some previous versions. My opinion is (1) if anyone want to test it, it is fine. ping me if you need help. (2) if nobody have chance testing it, I think we can merge it if we make sure it does not break existing functionalities (by code review, smoke test, manual test, etc). I have tested the feature manually, the new smoke test (test/integration/smoke/test_privategw_acl_ovs_gre.py) passed on kvm and xenserver. component test test_vpc_distributed_routing_offering.py passed on xenserver, but not on kvm as the feature is never implemented on kvm. if someone find bugs in their testing, we can fix them in next minor releases (4.16 will be LTS as far as I know) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
