GutoVeronezi opened a new pull request #5533: URL: https://github.com/apache/cloudstack/pull/5533
### Description In ACS, when we are listing public IPs to allocate, to a VPC, for instance, all IPs are listed, even the ones dedicated to an account different from the one that is calling the API. If we tried to allocate an IP dedicated to another account, ACS would return an error. Therefore, this PR intends to filter dedicated and non-dedicated VLANs in API `listPublicIPAddresses`. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### How Has This Been Tested? I tested locally, in a test lab. 1. Created VPCs to account `A` and `B`; 2. Dedicated some IPs to `A` and some`to `B`; 3. Enabled non-dedicated VLANs to A; 4. Before this change, account `A` would see non-dedicated and `B`'s IPs and `B` would see non-dedicated and `A`'s IPs. After this change, `A` only can see its IPs and non-dedicated and `B` only see its IPs as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
