davidjumani commented on a change in pull request #4339:
URL: https://github.com/apache/cloudstack/pull/4339#discussion_r719148241



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41520to41600.sql
##########
@@ -791,3 +791,6 @@ ALTER TABLE cloud.user_vm_details MODIFY value 
varchar(5120) NOT NULL;
 ALTER TABLE cloud_usage.usage_network DROP PRIMARY KEY, ADD PRIMARY KEY 
(`account_id`,`zone_id`,`host_id`,`network_id`,`event_time_millis`);
 ALTER TABLE `cloud`.`user_statistics` DROP INDEX `account_id`, ADD UNIQUE KEY 
`account_id`  
(`account_id`,`data_center_id`,`public_ip_address`,`device_id`,`device_type`, 
`network_id`);
 ALTER TABLE `cloud_usage`.`user_statistics` DROP INDEX `account_id`, ADD 
UNIQUE KEY `account_id`  
(`account_id`,`data_center_id`,`public_ip_address`,`device_id`,`device_type`, 
`network_id`);
+
+INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 3, 'listConfigurations', 'ALLOW', 
303) ON DUPLICATE KEY UPDATE rule=rule;

Review comment:
       Permissions can not be changed for default roles unless tweaking the DB, 
so IMO this is pretty safe




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to