weizhouapache commented on a change in pull request #5513:
URL: https://github.com/apache/cloudstack/pull/5513#discussion_r719363223
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -3879,6 +3879,8 @@ private void fillVMOrTemplateDetailOptions(final
Map<String, List<String>> optio
if (HypervisorType.KVM.equals(hypervisorType)) {
options.put(VmDetailConstants.ROOT_DISK_CONTROLLER,
Arrays.asList("osdefault", "ide", "scsi", "virtio"));
+ options.put(VmDetailConstants.VIDEO_HARDWARE,
Arrays.asList("cirrus", "vga", "qxl", "virtio"));
+ options.put(VmDetailConstants.VIDEO_RAM, Arrays.asList("16384",
"32768", "65536"));
Review comment:
would it better to change to the following ?
```
if (_videoModel != null && !_videoModel.isEmpty()) {
videoBuilder.append("<video>\n");
if (_videoRam != 0) {
videoBuilder.append("<model type='" + _videoModel + "'
vram='" + _videoRam + "'/>\n");
} else {
videoBuilder.append("<model type='" + _videoModel +
"'/>\n");
}
videoBuilder.append("</video>\n");
return videoBuilder.toString();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
