soreana commented on pull request #4774:
URL: https://github.com/apache/cloudstack/pull/4774#issuecomment-934221069
@sureshanaparti Sorry for the late we have an issue I've to check.
Regarding your test case (i) and (ii)
> (i)
>
> Domain1 config "restrict.public.template.access.to.domain": false and
Domain2 config "restrict.public.template.access.to.domain": true
> => The public templates of domain1 are not listed for domain2 admin.
> => The public templates of domain2 are listed for domain1 admin.
>
> (ii)
>
> Domain1 config "restrict.public.template.access.to.domain": true and
Domain2 config "restrict.public.template.access.to.domain": false
> => The public templates of domain1 are listed for domain2 admin.
> => The public templates of domain2 are not listed for domain1 admin.
>
(i) when you set Domain2's `restrict.public.template.access.to.domain` to
true, that means Domain2's templates will be available to other domains.
(current behavior). It doesn't care about what would be visible in this domain.
Let's clear it up with an example:
| Domain | `restrict.public.template.access.to.domain` | Templates |
| ----- | ----
| --------- |
| Domain1 | false
| X1, Y1 |
| Domain2 | true
| X2, Y2 |
What they will see when their admin list domains:
| Domain | List Templates Output |
| ----- | --------- |
| Domain1 | X1, Y1, X2, Y2 |
| Domain2 | X2, Y2 |
Cause `restrict.public.template.access.to.domain` sets to true in Domain2,
Domain2's access to see the public template was restricted. It is the same for
the (ii) test case.
@weizhouapache I got
https://github.com/apache/cloudstack/pull/4774#issuecomment-799156990 request
from @harikrishna-patnala to moved the setting to domain scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
