GabrielBrascher commented on a change in pull request #5410:
URL: https://github.com/apache/cloudstack/pull/5410#discussion_r724142409
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -2947,12 +2947,25 @@ protected void
createStoragePoolMappingsForVolumes(VirtualMachineProfile profile
executeManagedStorageChecksWhenTargetStoragePoolNotProvided(targetHost,
currentPool, volume);
if (ScopeType.HOST.equals(currentPool.getScope()) ||
isStorageCrossClusterMigration(plan.getClusterId(), currentPool)) {
createVolumeToStoragePoolMappingIfPossible(profile, plan,
volumeToPoolObjectMap, volume, currentPool);
- } else {
+ } else if (shouldMapVolume(profile, volume, currentPool)){
volumeToPoolObjectMap.put(volume, currentPool);
}
}
}
+ /**
+ * Returns true if it should map the volume for a storage pool to migrate.
+ * <br><br>
+ * Some context: VMware migration workflow requires all volumes to be
mapped (even if volume stays on its current pool);
Review comment:
Thanks for testing it @sureshanaparti!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
