DaanHoogland commented on a change in pull request #5594:
URL: https://github.com/apache/cloudstack/pull/5594#discussion_r735143810
##########
File path: server/src/main/java/com/cloud/network/Ipv6ServiceImpl.java
##########
@@ -324,7 +324,7 @@ public void updateNicIpv6(NicProfile nic, DataCenter dc,
Network network) {
if (routerIpv6Gateway == null) {
throw new CloudRuntimeException(String.format("Invalid
routerIpv6Gateway for network %s", network.getName()));
}
- final String routerIpv6Prefix =
routerIpv6Gateway.split("::")[0];
+ final String routerIpv6Prefix =
routerIpv6Gateway.split("::")[0] + "::";
Review comment:
let's create a utility `createIpv6PrefixFromGateway(String)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
