DaanHoogland commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r740842173
##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String
requestedIpv6) {
* address information.
*/
@Override
- public void setNicIp6Address(final NicProfile nic, final DataCenter dc,
final Network network) {
+ public void setNicIp6Address(final NicProfile nic, final DataCenter dc,
final Network network) throws InsufficientAddressCapacityException {
if (network.getIp6Gateway() != null) {
if (nic.getIPv6Address() == null) {
s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + "
for Network " + network);
nic.setIPv6Cidr(network.getIp6Cidr());
nic.setIPv6Gateway(network.getIp6Gateway());
+ if (nic.getBroadcastType() == null) {
+ nic.setBroadcastType(network.getBroadcastDomainType());
+ }
+ if (nic.getBroadCastUri() == null) {
+ nic.setBroadcastUri(network.getBroadcastUri());
+ }
+ if (nic.getMacAddress() == null) {
+
nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+ }
+
Review comment:
I sugest a method `setNicPropertiesFromNetwork(NicProfile nic, Network
network)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
