rhtyd commented on issue #5623: URL: https://github.com/apache/cloudstack/issues/5623#issuecomment-968748895
I'm fine with whatever the consensus is :) @PaulAngus - this was originally your issue, during primate SIG a lot of things were discussed over call which I used to collect and log. As I recall your idea was to consider the update API instead of start/stop API such that any role that can update a VM via should be allowed to see the console to make changes in a VM. Before David's fix (https://github.com/apache/cloudstack-primate/pull/469/files) there was no such check and the console button was shown to all roles/buttons. Can you review/LGTM on @SadiJr 's PR https://github.com/apache/cloudstack/pull/5625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
