rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r755026509
##########
File path: ui/src/views/infra/HostAdd.vue
##########
@@ -94,9 +94,8 @@
<a-input :placeholder="placeholder.username"
v-model="username"></a-input>
</div>
- <div class="form__item required-field"
v-if="selectedClusterHyperVisorType !== 'VMware'">
- <div class="form__label"><span class="required">* </span>{{
$t('label.password') }}</div>
- <span class="required required-label">{{ $t('label.required') }}</span>
+ <div class="form__item" v-if="selectedClusterHyperVisorType !==
'VMware'">
+ <div class="form__label">{{ $t('label.password') }}</div>
Review comment:
ping @weizhouapache when you've time - why not put explicit checks for
example a radio/button or toggle to switch between password or ssh-key auth
just for KVM (however for XenServer too this feature can be done).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
