joseflauzino opened a new pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713
### Description The unit tests of class `HostMetricsResponse` will fail when they're ran on machines with `locale` other than `en_US`. This happens because locales can have distinct decimal separators, for instance, `.` in `en_US` and `,` in `pt_BR`. This PR solves the mentioned problem by modifying the tests to use the decimal separator character according to the Locale set on the local machine (which is running the tests), instead of set it hardcoded. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [x] Minor - [ ] Trivial ### How Has This Been Tested? I ran the unit tests of class `HostMetricsResponse` with locale `pt_BR` and `en_US`. In both cases, the tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
