weizhouapache opened a new pull request #5730: URL: https://github.com/apache/cloudstack/pull/5730
### Description Currently shared networks and VPC private gateways can only be created from ROOT admin. This PR contains the following enhancement # 1. Create shared network offering with specifyvlan=false * specifyvlan MUST be true for shared network offering for now * specifyvlan can be true or false with this PR. # 2. Create shared network by non-ROOT users ## If specifyvlan=true in shared network offering vlan is required, it can be created/removed only by ROOT admin ## if specifyvlan=false in shared network offering All users can create shared network with an associated network (isolated networks), it will use the same vlan of associated network. If associated network is not specified, cloudstack will allocate a vlan from zone guest vlan ranges to the shared network. * ROOT admin and Domain admins can create shared network for domain (acltype=domain) and account (acltype=account) * Normal users can create shared network for account (acltype=account) * Associated network MUST be an Isolated network * Associated network MUST be owned by same account (if acltype=account) or in the same domain (if acltype=domain) * Associated network MUST be on same physical network as the new shared network. # 3. Create VPC private gateway by non-ROOT users ALL users can create VPC private gateway with an associated network. it will use the same vlan of associated network. * Associated network MUST be an Isolated network * Associated network MUST be owned by same account * Associated network MUST be on same physical network as the private gateway. * The private gateway will use the new system network offering : System-Private-Gateway-Network-Offering-Without-Vlan ROOT admin can create VPC private gateway with a specified vlan. It can only be removed by root admin either. The private gateway will use the new system network offering : System-Private-Gateway-Network-Offering # 4. List guest vlans in zone An API is introduced to list all guest vlans: listGuestVlans . It is only available by root admin. Guest vlans can be listed by * id * zoneid * physical network id * vnet (vlan id) * allocatedonly (true/false) <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [x] Major - [ ] Minor ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
